Add support for du_narendran_rusinowitch - #466
Merged
james-d-mitchell merged 2 commits intoAug 18, 2026
Merged
Conversation
james-d-mitchell
added
the
libsemigroups-feature-not-yet-supported
james-d-mitchell
force-pushed
the
du-narendran-rusinowitch
branch
from
August 14, 2026 10:56
3c1121f to
9dc591f
Compare
james-d-mitchell
force-pushed
the
du-narendran-rusinowitch
branch
from
August 14, 2026 13:02
9dc591f to
c6eee72
Compare
Co-authored-by: James Mitchell <jdm3@st-andrews.ac.uk>
Joseph-Edwards
force-pushed
the
du-narendran-rusinowitch
branch
from
August 18, 2026 09:04
c6eee72 to
0f45174
Compare
Joseph-Edwards
requested changes
Aug 18, 2026
Joseph-Edwards
left a comment
Joseph-Edwards
left a comment
Collaborator
There was a problem hiding this comment.
After changing our definition of RPO, du_narendran_rusinowitch finds orders on the alphabets such that rules are oriented with respect to reverse-RPO. If we make this change, and the small test tweak, I will be happy to merge. Thanks!
Co-authored-by: Joe Edwards <80713360+Joseph-Edwards@users.noreply.github.com>
james-d-mitchell
enabled auto-merge (rebase)
August 18, 2026 10:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the functionality introduced into libsemigroups in:
libsemigroups/libsemigroups#1010